Fix/root detection #185
Fix/root detection #185
Conversation
Signed-off-by: ubi de feo <me@ubidefeo.com>
There was a problem hiding this comment.
Copilot reviewed 27 out of 29 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- package.json: Language not supported
- ui/arduino/main.css: Language not supported
Comments suppressed due to low confidence (1)
ui/arduino/store.js:1633
- There is a potential memory leak here because every new tab registers an onChange listener without removing it when the tab is closed. Consider implementing a cleanup to remove the listener upon tab closure.
newFile.editor.onChange = function() { newFile.hasChanges = true; emitter.emit('render') }
| let tooltipEl = html`` | ||
| if (tooltip) { | ||
| tooltipEl = html`<div class="tooltip">${tooltip}</div>` | ||
| } | ||
| tooltipEl = html`` |
There was a problem hiding this comment.
Resetting tooltipEl to an empty value immediately after conditionally setting it discards any provided tooltip content. Remove or adjust this line so that the tooltip renders as intended.
| tooltipEl = html`` | |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
Converted to Draft since creation of files still somehow defaults to |
Signed-off-by: ubi de feo <me@ubidefeo.com>
Signed-off-by: ubi de feo <me@ubidefeo.com>
Signed-off-by: ubi de feo <me@ubidefeo.com>
| @@ -30,3 +40,5 @@ def delete_folder(path): | |||
| if file['type'] == 'folder': | |||
| os.rmdir(file['path']) | |||
| os.rmdir(path) | |||
|
|
|||
| os.chdir(get_root()) | |||
There was a problem hiding this comment.
It should not be necessary to change to the root. The system should be mounted by default there. Unless someone is using some code that changes that. Then again, the board does a soft reset when connecting. Can you elaborate?
There was a problem hiding this comment.
Unless someone is using some code that changes that
exactly this
Signed-off-by: ubi de feo <me@ubidefeo.com>
… mount-point. Signed-off-by: ubi de feo <me@ubidefeo.com>
This PR introduces detection of board's default root path, which may be
/or/flashdepending on ports.It seems that it will eventually standardise to
/flashfollowing the introduction of ROMFS.A typical scenario will be as described in this comment related to MAPFS (later called ROMFS)
micropython/micropython#8381 (comment)
With
/not being directly writable unless wanted by someone producing their own custom build, but I'd rather be future-proof with this double-handling based on the presence of/flashinsys.path.With this PR the creation of a new program will happen in
/flashfor boards which are already mounting the main file-system there and default to/for other platforms.Eventually all platforms should follow custom even if a board will never use an SD card or have ROMFS